Use common CSM baseimage #271
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donatwork
reviewed
Jan 27, 2025
build.sh
Outdated
Comment on lines
33
to
34
| echo $BUILDCMD build ${NOCACHE} -t ${IMAGE_NAME}:${IMAGE_TAG} GOIMAGE=$DEFAULT_GOIMAGE BASEIMAGE=$CSM_BASEIMAGE . | ||
| (cd .. && $BUILDCMD build --pull ${NOCACHE} -t ${IMAGE_NAME}:${IMAGE_TAG} --build-arg GOIMAGE=$DEFAULT_GOIMAGE --build-arg BASEIMAGE=$CSM_BASEIMAGE --build-arg GOPROXY=$GOPROXY -f csi-unity/Dockerfile.podman . --format=docker) |
There was a problem hiding this comment.
Can we get rid of this file altogether? Seems that it may have been part of some legacy build/test framework. Why not push things back into the Makefile?
There was a problem hiding this comment.
Fixed. New cert-csi VolumeIO run also passed
donatwork
reviewed
Feb 1, 2025
| podman-push: download-csm-common go-build | ||
| $(eval include csm-common.mk) | ||
| sh build.sh --baseubi $(DEFAULT_BASEIMAGE) --goimage $(DEFAULT_GOIMAGE) --push | ||
| podman build --pull -t $(IMAGE_REGISTRY)/$(IMAGE_NAME):$(IMAGE_TAG) --build-arg GOIMAGE=$(DEFAULT_GOIMAGE) --build-arg BASEIMAGE=$(CSM_BASEIMAGE) --build-arg GOPROXY=$(GOPROXY) . --format=docker | ||
|
|
||
| podman-build-no-cache: download-csm-common go-build |
There was a problem hiding this comment.
Is the go-build still needed since the build is being done in the Docker image build?
donatwork
reviewed
Feb 1, 2025
|
|
||
| # | ||
| # Docker-related tasks | ||
| # | ||
| # Generates the docker container (but does not push) | ||
| docker-build: go-build | ||
| docker-build: download-csm-common go-build |
There was a problem hiding this comment.
Is the go-build still needed since the build is being done in the Docker image build?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converting csi-unityto use the common dellemc/csm-base-image (which is based on ubi-micro) instead of the ubi micro image directly.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration